Skip to content

python3Packages.metar: disable failing test#165336

Closed
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:metar-fix
Closed

python3Packages.metar: disable failing test#165336
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:metar-fix

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Mar 22, 2022

Description of changes

Fix build (https://hydra.nixos.org/build/169519201)

Should fix failure of nws test of #165293.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners March 22, 2022 21:32
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 22, 2022
@fabaff
Copy link
Member Author

fabaff commented Mar 22, 2022

Result of nixpkgs-review pr 165336 run on x86_64-linux 1

5 packages built:
  • home-assistant-component-tests.nws
  • python310Packages.metar
  • python310Packages.pynws
  • python39Packages.metar
  • python39Packages.pynws

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 22, 2022
@fabaff
Copy link
Member Author

fabaff commented Mar 22, 2022 •
edited
Loading

Was already fixed in #162538.

@fabaff fabaff closed this Mar 22, 2022
@fabaff fabaff deleted the metar-fix branch March 22, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fabaff