Skip to content

alda: 2.0.6 -> 2.2.0#165182

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
fleimgruber:master
Mar 23, 2022
Merged

alda: 2.0.6 -> 2.2.0#165182
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
fleimgruber:master

Conversation

@fleimgruber
Copy link
Contributor

Description of changes

Motivated by alda-lang/alda#411

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ericdallo March 21, 2022 22:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 21, 2022
@SuperSandro2000 SuperSandro2000 merged commit 4e33e49 into NixOS:master Mar 23, 2022
@fleimgruber
Copy link
Contributor Author

@github-actions
Copy link
Contributor

Backport failed for release-21.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-21.11
git worktree add -d .worktree/backport-165182-to-release-21.11 origin/release-21.11
cd .worktree/backport-165182-to-release-21.11
git checkout -b backport-165182-to-release-21.11
ancref=$(git merge-base cf7556eea5a1477c87dbb4caf90cb896ec4d6ee8 90e831473c469efbc7414db16f7baffdbb538bfc)
git cherry-pick -x $ancref..90e831473c469efbc7414db16f7baffdbb538bfc

@SuperSandro2000
Copy link
Member

You need to create the PR manually because probably some other commit is missing and causes a merge conflict.

@fleimgruber
Copy link
Contributor Author

Thanks, will do!

@fleimgruber
Copy link
Contributor Author

fleimgruber commented Apr 4, 2022

For reference, manual backport PR is #167042.

@fleimgruber fleimgruber mentioned this pull request Jul 22, 2022
13 tasks
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants