nixos services.xserver.displayManager.session: drop type#164895
Merged
vcunat merged 1 commit intoNixOS:masterfrom Mar 19, 2022
Merged
nixos services.xserver.displayManager.session: drop type#164895vcunat merged 1 commit intoNixOS:masterfrom
vcunat merged 1 commit intoNixOS:masterfrom
Conversation
vcunat
added
6.topic: nixos
github-actions
bot
added
the
8.has: module (update)
Member
Author
|
OMG no... a type-less option is not allowed now? |
For now at least. I expect someone will find a working type later. It's incorrect and was causing bad issues. Example test case: nix-instantiate nixos/release.nix -A tests.xfce.x86_64-linux --dry-run This is a partial revert of commit b2d803c from PR NixOS#162271.
vcunat
force-pushed
the
p/dm-session-typing
branch
from
8dbf646 to
fd609f9
Compare
ofborg
bot
added
10.rebuild-darwin: 0
cole-h
approved these changes
Mar 19, 2022
Member
Author
|
I was impatient with this. |
Member
Glad it's working, that's the goal of #162271 :) This reversal looks good for now. While |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now at least. I expect someone will find a working type later.
It's incorrect and was causing bad issues. Example test case:
nix-instantiate nixos/release.nix -A tests.xfce.x86_64-linux --dry-run
This is a partial revert of commit b2d803c from PR #162271.