Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 19, 2022

This commit is the result of running

pkgs/development/compilers/rust/print-hashes.sh 1.57.0

in order to generate the bootstrap hash for
mips64el-unknown-linux-gnuabi64. This commit is needed in order to
bootstrap nix on mips64el because nix_2_4 depends on rustc.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This commit is the result of running

  pkgs/development/compilers/rust/print-hashes.sh 1.57.0

in order to generate the bootstrap hash for
mips64el-unknown-linux-gnuabi64.  This commit is needed in order to
bootstrap nix on mips64el because nix_2_4 depends on rustc.
@ghost ghost requested review from LnL7, Mic92 and zowoq as code owners March 19, 2022 18:00
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Mar 19, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 19, 2022
@happysalada
Copy link
Contributor

looks good to me

@happysalada happysalada merged commit 852c8ab into NixOS:master Mar 19, 2022
@ghost ghost deleted the update-rustc-bootstrap-tarball-hashes branch March 19, 2022 20:58
@zowoq
Copy link
Contributor

zowoq commented Mar 19, 2022

As I said in #162070 (comment), with 1.59 in staging this hash will be incorrect and it causes a merge conflict as well.

Reverted in 6b5006b.

@zowoq
Copy link
Contributor

zowoq commented Mar 19, 2022

I've opened a PR to add it to 1.59 in staging: #164901

A new staging-next branch should start in a few days and then it will be in master.

@ghost
Copy link
Author

ghost commented Mar 19, 2022

As I said in #162070 (comment),

Sorry, I forgot about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants