nixos/testing: restrict arguments to makeTest#164660
Merged
roberth merged 9 commits intoNixOS:masterfrom Mar 24, 2022
Merged
Conversation
github-actions
bot
added
the
6.topic: nixos
ncfavier
commented
Mar 18, 2022
nixos/tests/without-nix.nix
Outdated
Comment on lines
7
to
12
Member
Author
There was a problem hiding this comment.
@Ericson2314 note that the test fails if I add this to the actual machine configuration.
Disallow passing arbitrary arguments to makeTest since they are not used; this can help catch mistakes.
Fixes errors caught by "nixos/testing: restrict arguments to makeTest" as well as some unrelated errors and warnings.
ncfavier
force-pushed
the
tests-restrict-arguments
branch
from
31c8308 to
ca8c877
Compare
ofborg
bot
added
10.rebuild-darwin: 0
github-actions
bot
added
the
8.has: module (update)
ncfavier
commented
Mar 21, 2022
roberth
reviewed
Mar 21, 2022
toFunction isn't quite the same as callPackage, but the difference should only be relevant for cross pkgs, which are generally not testable anyway.
roberth
force-pushed
the
tests-restrict-arguments
branch
from
1f358d1 to
b2d3baa
Compare
ofborg
bot
added
2.status: merge conflict
Member
Author
|
LGTM! |
Member
|
The chromium package wasn't buildable. @ofborg test caddy ceph-multi-node cri-o |
roberth
approved these changes
Mar 24, 2022
Member
|
Awesome. Thank you @ncfavier ! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disallow passing arbitrary arguments to
makeTestsince they are not used; this can help catch mistakes.Then fix those mistakes, as well as some unrelated errors and warnings.