Skip to content

Comments

meson: patch for not hard failing on positional arguments passed to i…#164400

Closed
NickCao wants to merge 1 commit intoNixOS:stagingfrom
NickCao:meson-patch
Closed

meson: patch for not hard failing on positional arguments passed to i…#164400
NickCao wants to merge 1 commit intoNixOS:stagingfrom
NickCao:meson-patch

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Mar 16, 2022

Description of changes

Prepare for possible breakages in packages depending on meson (mostly gnome related)
Waiting for gnome 42 tarball to make the final decision.
ref: #164266 #154833
cc: @jtojnar @bobby285271

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from AndersonTorres and jtojnar March 16, 2022 11:18
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 16, 2022
jtojnar
jtojnar approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GNOME 42 release is scheduled for 23th, IIRC. So new staging cycle will likely start before that.

Verified that it fixes gnome-bluetooth build.

@NickCao
Copy link
Member Author

NickCao commented Mar 17, 2022

GNOME 42 release is scheduled for 23th, IIRC. So new staging cycle will likely start before that.

Verified that it fixes gnome-bluetooth build.

According to https://wiki.gnome.org/FortyTwo, tarballs should be due at 3/19, we may get a head start.

@jtojnar
Copy link
Member

jtojnar commented Mar 17, 2022

I am pretty sure there will be stragglers. And we will still need to do testing.

@AndersonTorres AndersonTorres changed the title [do not merge] meson: patch for not hard failing on potitional arguments passed to i… [do not merge] meson: patch for not hard failing on positional arguments passed to i… Mar 20, 2022
@AndersonTorres AndersonTorres marked this pull request as draft March 20, 2022 13:12
@AndersonTorres AndersonTorres changed the title [do not merge] meson: patch for not hard failing on positional arguments passed to i… meson: patch for not hard failing on positional arguments passed to i… Mar 20, 2022
@NickCao NickCao closed this Apr 6, 2022
@NickCao NickCao deleted the meson-patch branch April 6, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

No open projects
Staging
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickCao @jtojnar