wxwidgets: fix building 3.1 on darwin#163335
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Mar 23, 2022
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
Contributor
Author
|
@tfmoraes thanks, haven’t seen it, as I was not looking in staging. Once it reaches master, maybe this PR could be useful, since it fixes building on darwin? |
knl
force-pushed
the
wxwidgets-3.1-update
branch
from
5226418 to
85fda9a
Compare
Contributor
Author
|
@tfmoraes I updated the PR to make 3.1 build on darwin. Please take a look. I'm wondering should we carve out a dedicated version without gtk, just for mac? |
knl
force-pushed
the
wxwidgets-3.1-update
branch
from
85fda9a to
7d8d130
Compare
ofborg
bot
added
10.rebuild-linux: 0
tfmoraes
reviewed
Mar 18, 2022
knl
force-pushed
the
wxwidgets-3.1-update
branch
from
7d8d130 to
73afef8
Compare
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-linux: 11-100
tfmoraes
approved these changes
Mar 22, 2022
Fix building on darwin by passing in all the dependencies and removing compilation switches that do not exist anymore.
knl
force-pushed
the
wxwidgets-3.1-update
branch
from
4610b9c to
b22a1d1
Compare
DarkKirb
added a commit
to DarkKirb/nixos-config
that referenced
this pull request
Mar 25, 2022
NixOS/nixpkgs#163335 introduced a regression that we are affected by
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix build failures on darwin by passing all the necessary dependencies and removing deprecated command line switches to configure.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes