Skip to content

[Backport release-21.11] nixos/nix-daemon: Ensure continued availability of daemon socket#163323

Merged
jonringer merged 1 commit intorelease-21.11from
backport-161059-to-release-21.11
Mar 8, 2022
Merged

[Backport release-21.11] nixos/nix-daemon: Ensure continued availability of daemon socket#163323
jonringer merged 1 commit intorelease-21.11from
backport-161059-to-release-21.11

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2022

Bot-based backport to release-21.11, triggered by a label in #161059.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

As `nix-daemon.service` does not make use of `ExecStop`, we prefer
to keep the socket up and available. This is important for machines
that run Nix-based services, such as automated build, test, and deploy
services, that expect the daemon socket to be available at all times.

See committed inline comment for further explanation.

(cherry picked from commit b550b4b)
@github-actions github-actions bot requested a review from jonringer as a code owner March 8, 2022 13:31
@github-actions github-actions bot requested a review from tomberek March 8, 2022 13:31
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 8, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants