Skip to content

Comments

libc++, libc++abi, lldb: fix 3.8#16323

Merged
vcunat merged 1 commit intoNixOS:masterfrom
Ralith:llvm
Jun 20, 2016
Merged

libc++, libc++abi, lldb: fix 3.8#16323
vcunat merged 1 commit intoNixOS:masterfrom
Ralith:llvm

Conversation

@Ralith
Copy link
Contributor

@Ralith Ralith commented Jun 19, 2016

Motivation for this change

When LLVM and clang were updated to 3.8, libc++, libc++abi, and lldb were skipped, leaving them with incorrect hashes and broken builds. This gets them building again.

I don't have OSX to test on, so the tweaked darwin patch should be reviewed by someone who does.

This fix should probably be backported to all branches that contain llvm 3.8, including nixos-16.03.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @andrewrk and @acowley to be potential reviewers

@vcunat vcunat merged commit 46ae67d into NixOS:master Jun 20, 2016
vcunat added a commit that referenced this pull request Jun 20, 2016
@vcunat
Copy link
Member

vcunat commented Jun 20, 2016

The bad hashes were fixed a about month ago #15252. Your merge base is older than that (nixpkgs channel is very old now). But the rest of the fixes was still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants