libc++, libc++abi, lldb: fix 3.8#16323
Merged
vcunat merged 1 commit intoNixOS:masterfrom Jun 20, 2016
Merged
Conversation
vcunat
added a commit
that referenced
this pull request
Jun 20, 2016
Member
|
The bad hashes were fixed a about month ago #15252. Your merge base is older than that (nixpkgs channel is very old now). But the rest of the fixes was still missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When LLVM and clang were updated to 3.8, libc++, libc++abi, and lldb were skipped, leaving them with incorrect hashes and broken builds. This gets them building again.
I don't have OSX to test on, so the tweaked darwin patch should be reviewed by someone who does.
This fix should probably be backported to all branches that contain llvm 3.8, including nixos-16.03.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)