logrotate: move mail dependency from package to service#162225
Closed
martinetd wants to merge 1 commit intoNixOS:masterfrom
Closed
logrotate: move mail dependency from package to service#162225martinetd wants to merge 1 commit intoNixOS:masterfrom
martinetd wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
5 tasks
martinetd
force-pushed
the
logrotate_mail
branch
from
c266745 to
760389f
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
ju1m
reviewed
Feb 28, 2022
having pkgs.logrotate depend on mailutils brings in quite a bit of dependencies through mailutil itself and recursive dependency to guile when most people do not need it. Remove mailutils dependency from the package, and conditionally add it to the service if the user specify the mail option either at top level or in a path Fixes NixOS#162001
martinetd
force-pushed
the
logrotate_mail
branch
from
760389f to
83edf7c
Compare
ius
approved these changes
Mar 4, 2022
Contributor
ius
left a comment
ius
left a comment
There was a problem hiding this comment.
This resolves the immediate issue. Thanks!
Member
|
@ofborg test logrotate |
Member
Author
|
Closing, this has been merged as part of #162063 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
having pkgs.logrotate depend on mailutils brings in quite a bit of dependencies
through mailutil itself and recursive dependency to guile when most people
do not need it.
Remove mailutils dependency from the package, and conditionally add it to the
service if the user specify the mail option either at top level or in a path
Fixes #162001
This supersedes the "mail" part of #162063 which has grown bigger/more complicated than planned, and will continue its own life at a slower pace.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)