Skip to content

.github/CODEOWNERS: remove non-committer users/teams#162044

Merged
zowoq merged 1 commit intoNixOS:masterfrom
qowoz:codeowner-error
Mar 29, 2022
Merged

.github/CODEOWNERS: remove non-committer users/teams#162044
zowoq merged 1 commit intoNixOS:masterfrom
qowoz:codeowner-error

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 27, 2022

these didn't work anyway and now github warns if they don't have commit access

https://github.com/NixOS/nixpkgs/blob/b71ebb32cedef576181e519380f42d1e2fc5d312/.github/CODEOWNERS

codeowners

@zowoq zowoq requested a review from edolstra as a code owner February 27, 2022 04:20
@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Feb 27, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 27, 2022
@teto
Copy link
Member

teto commented Feb 27, 2022

can't we instead setup the teams so that they have write access ? gnome team implies triage for now for instance.

@zowoq
Copy link
Contributor Author

zowoq commented Feb 28, 2022

can't we instead setup the teams so that they have write access ?

Not with the way we currently use teams as they have members who don't already have write access.

@teto
Copy link
Member

teto commented Feb 28, 2022

it's sad that we can use only teams with write access (it is normal according to docs https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners)

Have you looked for any github ticket to allow teams with RO access ?
Maybe we could create a team with write access instead ? like gnome-RW

@zowoq
Copy link
Contributor Author

zowoq commented Feb 28, 2022

Have you looked for any github ticket to allow teams with RO access ?

No.

Maybe we could create a team with write access instead ? like gnome-RW

Out of scope of this PR, creating new teams (and new types of teams) can be discussed elsewhere.

these didn't work anyway and now github warns if they don't have commit access
@zowoq
Copy link
Contributor Author

zowoq commented Mar 23, 2022

Now we have another team with commit access definitely seems simpler to just limit this file to users/teams with commit access so we can benefit from the github warnings and avoid any confusion.

@zowoq zowoq requested a review from zimbatm March 23, 2022 00:09
@SuperSandro2000
Copy link
Member

What do you think about pinging the teams so that they know they need to fix this?

@zowoq
Copy link
Contributor Author

zowoq commented Mar 23, 2022

What do you think about pinging the teams so that they know they need to fix this?

There isn't anything to be fixed here, this is basically just cleaning up dead code. The members of the gnome, php and podman teams that that have commit access are already listed here alongside the team. The darwin team has ~45 people, mostly non-committers. I think asking people to add themselves as new darwin codeowners is out of scope for this PR.

@zowoq zowoq merged commit 630732f into NixOS:master Mar 29, 2022
@zowoq zowoq deleted the codeowner-error branch March 29, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants