Skip to content

python310Packages.sanic: disable due to GHSA-7p79-6x2v-5h88#161869

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
risicle:ris-sanic-python310-disable
Mar 5, 2022
Merged

python310Packages.sanic: disable due to GHSA-7p79-6x2v-5h88#161869
mweinelt merged 1 commit intoNixOS:masterfrom
risicle:ris-sanic-python310-disable

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Feb 25, 2022 •
edited
Loading

Motivation for this change

GHSA-7p79-6x2v-5h88

Sanic doesn't support python 3.10 yet and attempting to use it opens users to a DoS attack. Disable for now.

No backport needed as we don't have python310 in 21.11.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 25, 2022
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 25, 2022
@risicle
python310Packages.sanic: disable due to GHSA-7p79-6x2v-5h88
bf149c4 
sanic doesn't support python 3.10 yet and attempting to use it
opens users to a DoS attack
@risicle risicle force-pushed the ris-sanic-python310-disable branch from 9fe7f84 to bf149c4 Compare February 25, 2022 19:08
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 25, 2022
fabaff
fabaff reviewed Feb 26, 2022
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20.12.6 adds a check for Python 3.10.

Would us require to go with 21.12.1 to enable it for Python 3.10 again.

@risicle
Copy link
Contributor Author

risicle commented Feb 26, 2022

The advisory claims that no version is python 3.10 compatible.

@mweinelt mweinelt merged commit 295bb46 into NixOS:master Mar 5, 2022
@rehno-lindeque rehno-lindeque mentioned this pull request Mar 18, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@risicle @fabaff @mweinelt