Skip to content

dante: skip configure-time getaddrinfo-too-low check on mips64#161177

Merged
Ericson2314 merged 1 commit intomasterfrom
unknown repository
Apr 1, 2022
Merged

dante: skip configure-time getaddrinfo-too-low check on mips64#161177
Ericson2314 merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Feb 21, 2022

This patch allows dante to be compiled (and cross-compiled) for mips64el.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • mips64el-gnuabi64 (cross from x86_64-linux)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Feb 21, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 21, 2022
@ghost
Copy link
Author

ghost commented Feb 23, 2022

Latest push rebases against #161158, no other changes.

@github-actions github-actions bot removed the 6.topic: stdenv Standard environment label Mar 18, 2022
@ghost
Copy link
Author

ghost commented Mar 18, 2022

Rebased. #161158 has merged, so this PR is usable now.

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 18, 2022
@ghost
Copy link
Author

ghost commented Mar 31, 2022

Ping...

Ericson2314
Ericson2314 reviewed Mar 31, 2022
View reviewed changes
@ghost
Copy link
Author

ghost commented Mar 31, 2022

(collapsed to one commit)

@Ericson2314
dante: skip configure-time getaddrinfo-too-low check on mips64
aeb47fa 
This patch allows dante to be compiled (and cross-compiled) for mips64el.

Co-authored-by: John Ericson <[email protected]>
@Ericson2314 Ericson2314 merged commit 8dc7ebc into NixOS:master Apr 1, 2022
@ghost ghost deleted the dante-mips64 branch April 1, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@nbp nbp Awaiting requested review from nbp

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Ericson2314