mips64: have mips64el chips auto-detect abi=n64 #161159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Ericson2314,
alyssais,
matthewbauer and
nbp
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
Author
|
Latest push rebases against #161158 ; no other changes. |
This was referenced Feb 24, 2022
Merged
Author
|
Latest push rebases against #161158; no other changes. |
Author
|
Latest push rebases on #161158, no other changes. |
ofborg
bot
added
the
10.rebuild-linux-stdenv
ofborg
bot
added
10.rebuild-darwin: 11-100
github-actions
bot
added
6.topic: golang
github-actions
bot
removed
the
6.topic: golang
Author
|
Rebased. #161158 has merged, so this PR is useful now. |
ofborg
bot
added
10.rebuild-darwin: 0
Mic92
reviewed
Mar 20, 2022
Member
|
It looks like some platforms you added don't evaluate. This problem is also present on master. I noticed this in nix-community/cross-toolchains.nix#19 as well |
Author
ghost
changed the title
This PR adds an additional two-line patch to the code which calculates a `hostPlatform` based on the `builtins.system` provided by the `nix` interpreter, which is in turn derived from the runtime CPU. If the runtime CPU is a 64-bit mips chip running on a little-endian kernel, and the user has not specified otherwise, this commit will cause nixpkgs to assume the "n64" ABI. All mips64 chips are capable of supporting all the mips ABIs. The n64 ABI was chosen because boost's user-scheduled threading (which nix requires) currently does not support the n32 ABI -- it lacks the assembler file which explains how to save and restore the processor state for that ABI. This is also the ABI that Debian has chosen for this platform.
Author
|
Rebased and commit comment updated to clarify that assumptions are being introduced only for the ABI. The CPU type is detected by the Also clarifies that the ABI choice is the same one Debian uses. |
ghost
mentioned this pull request
3 tasks
ghost
marked this pull request as draft
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional two-line patch to the code which calculates a
hostPlatformbased on thebuiltins.systemprovided by thenixinterpreter, which is in turn derived from the runtime CPU.If the runtime CPU is a 64-bit mips chip running on a little-endian kernel, and the user has not specified otherwise, this commit will cause nixpkgs to assume the "n64" ABI.
All mips64 chips are capable of supporting all the mips ABIs.
The n64 ABI was chosen because boost's user-scheduled threading (which nix requires) currently does not support the n32 ABI -- it lacks the assembler file which explains how to save and restore the processor state for that ABI. This is also the ABI that Debian has chosen for this platform.
Things done