Skip to content

dpcmd: Init package#160847

Closed
felixsinger wants to merge 1 commit intoNixOS:masterfrom
felixsinger:pkgs/dpcmd/init
Closed

dpcmd: Init package#160847
felixsinger wants to merge 1 commit intoNixOS:masterfrom
felixsinger:pkgs/dpcmd/init

Conversation

@felixsinger
Copy link
Member

Motivation for this change

Init package. WIP.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Signed-off-by: Felix Singer <felixsinger@posteo.net>

stdenv.mkDerivation rec {
pname = "dpcmd";
version = "1.2";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do here if the developers don't specify a version?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the version to unstable-YYYY-MM-DD; that's what I was told to do for the em100 package.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 19, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title should be dpcmd: init at ${version}.

People use this pattern (and package: ${oldver} -> ${newver}) to filter the flood of PRs that nixpkgs gets.


stdenv.mkDerivation rec {
pname = "dpcmd";
version = "1.2";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the version to unstable-YYYY-MM-DD; that's what I was told to do for the em100 package.

description = "Linux software for SF100/SF600";
license = licenses.gpl2;
maintainers = with maintainers; [ felixsinger ];
platforms = platforms.linux;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = platforms.linux;
platforms = platforms.unix;

Is there something about the software that fundamentally cannot work on other unices? I know upstream put "Linux" in the name of the package, but there are no Linux-specific #includes...

Overly-restrictive meta.platforms settings are really annoying to people who don't use x86_64-linux. Nixpkgs shouldn't throw simply because nobody's tried a particular platform/package combination yet...

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 21, 2022
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 1, 2025
@felixsinger
Copy link
Member Author

not needed anymore as it was packaged by someone else.

@felixsinger felixsinger closed this Dec 4, 2025
@felixsinger felixsinger deleted the pkgs/dpcmd/init branch December 4, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants