flake/nixosSystem: pass the final lib to eval-config.nix#160459
Closed
ncfavier wants to merge 2 commits intoNixOS:masterfrom
Closed
flake/nixosSystem: pass the final lib to eval-config.nix#160459ncfavier wants to merge 2 commits intoNixOS:masterfrom
ncfavier wants to merge 2 commits intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
reviewed
Feb 17, 2022
lib/fixed-points.nix
Outdated
Comment on lines
110
to
112
Member
There was a problem hiding this comment.
(see also #157056 (comment) for why this is necessary)
Makes lib extensions available in modules by default
This is necessary for `lib` to still be extensible in the modules evaluated by `evalModules`. Also inline the call to `fix'` for performance.
ncfavier
force-pushed
the
nixosSystem-lib
branch
from
ef8a44f to
73031b6
Compare
Member
Author
|
Updated as per discussion in #157056 (comment) |
Member
Author
|
Even if #157056 is too much, I think this should go through. Should we have a vote? |
Member
|
This looks innocent, but it is a significant shift in what Currently:
After this:
So this doesn't look like an unambiguous improvement. |
13 tasks
stale
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #157056. The
makeExtensiblefix isn't strictly necessary for this but seems reasonable regardless.