Skip to content

nixos/*: cleanup#160358

Closed
jonringer wants to merge 6 commits intoNixOS:masterfrom
jonringer:fix-unstable-eval
Closed

nixos/*: cleanup#160358
jonringer wants to merge 6 commits intoNixOS:masterfrom
jonringer:fix-unstable-eval

Conversation

@jonringer
Copy link
Copy Markdown
Contributor

@jonringer jonringer commented Feb 16, 2022

Motivation for this change

Trying to find out why nixos-unstable fails to evaluate. But found some other eval traces.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 16, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 16, 2022
@jonringer
Copy link
Copy Markdown
Contributor Author

jonringer commented Feb 16, 2022

@GrahamcOfBorg test peertube step-ca jitsi-meet jibri discourse caddy

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 1, 2022
dasj19
dasj19 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2023
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 7, 2023
@jonringer
Copy link
Copy Markdown
Contributor Author

jonringer commented Nov 23, 2023

a lot of these are no longer relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dasj19 dasj19 dasj19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonringer @dasj19 @wegank