Skip to content

Move misc/vim-plugins to applications/editors/vim/plugins#160336

Merged
AndersonTorres merged 6 commits intoNixOS:masterfrom
AndersonTorres:move-editor-plugins
Feb 25, 2022
Merged

Move misc/vim-plugins to applications/editors/vim/plugins#160336
AndersonTorres merged 6 commits intoNixOS:masterfrom
AndersonTorres:move-editor-plugins

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Feb 16, 2022

Motivation for this change

This patch diminishes clutter in pkgs/misc and puts the plugins folder in a more intuitive place.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation labels Feb 16, 2022
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Feb 16, 2022

Oh an emacser modifying the vim scripts? I swear I am not sabotaging!

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 16, 2022
@teto
Copy link
Member

teto commented Feb 16, 2022

haven't check the PR itself but I agree with the principle. it would be more coherent with paths like ./pkgs/applications/editors/kakoune

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Feb 17, 2022

Now the script list is updated

@teto
Copy link
Member

teto commented Feb 17, 2022

You need to update the .github/{CODEOWNERS/labeler.yaml} too. I dont mind testing and merging this but I would like some other vim-plugins maintainers' approval as this is disruptive to existing PRs.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2022
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Feb 18, 2022

@teto

You need to update the .github/{CODEOWNERS/labeler.yaml} too.

Why exactly? Are those file path-related?

I dont mind testing and merging this but I would like some other vim-plugins maintainers' approval as this is disruptive to existing PRs.

It can be merged after them.

@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Feb 18, 2022
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Feb 19, 2022

@jonringer

@ofborg ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 24, 2022
@AndersonTorres
Move misc/vim-plugins to applications/editors/vim/plugins
3f19fc3
@AndersonTorres
vim: Update .github/CODEOWNERS and .github/labeler.yml
b71ebb3
@AndersonTorres
vim: update the updaters!
b2a83e3 
update.py and its companion update-shell.nix need to know where they are, else
they can't find the root default.nix of Nixpkgs. Because of this, I further
added a small piece of documentation about those path-dependent pieces of code.
@AndersonTorres
vim-plugin-names: updates
939e2fa 
+ liuchengxu/space-vim
+ SpaceVim/SpaceVim
@AndersonTorres
vimPlugins: update
93bc3c2
@AndersonTorres
vimPlugins: update
dd88285
@AndersonTorres AndersonTorres merged commit cabaf93 into NixOS:master Feb 25, 2022
@AndersonTorres AndersonTorres mentioned this pull request Aug 6, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: vim Advanced text editor 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndersonTorres @teto