pythonPackages.torchdata: init at 0.3.0a1-e86cedc#160213
Closed
rehno-lindeque wants to merge 1 commit intoNixOS:masterfrom
Closed
pythonPackages.torchdata: init at 0.3.0a1-e86cedc#160213rehno-lindeque wants to merge 1 commit intoNixOS:masterfrom
rehno-lindeque wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
rehno-lindeque
force-pushed
the
torchdata-0.3.0
branch
from
46ad910 to
0d35c27
Compare
15 tasks
stale
bot
added
the
2.status: stale
SuperSandro2000
requested changes
Jun 18, 2023
| description = "A PyTorch repo for data loading and utilities to be shared by the PyTorch domain libraries."; | ||
| homepage = "github.com/pytorch/data"; | ||
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ ]; |
| rarfile | ||
| torchaudio | ||
| torchtext | ||
| # iopath |
Member
There was a problem hiding this comment.
Suggested change
| # iopath |
Comment on lines
+28
to
+29
| # rev = "v${version}"; | ||
| rev = "e86cedc5ffd024ea293f541fc77e8a3b4856c8c9"; # git branch release/0.3.0 |
Member
There was a problem hiding this comment.
Can this be changed back?
|
|
||
| buildPythonPackage rec { | ||
| pname = "torchdata"; | ||
| version = "0.3.0a1-e86cedc"; |
Member
There was a problem hiding this comment.
This should use the unstable format
| , rarfile | ||
| , torchaudio | ||
| , torchtext | ||
| # , iopath |
Member
There was a problem hiding this comment.
Suggested change
| # , iopath |
Comment on lines
+4
to
+9
|
|
||
| # Propogated build inputs | ||
| , pytorch | ||
| , requests | ||
|
|
||
| # Check inputs |
Member
There was a problem hiding this comment.
Suggested change
| # Propogated build inputs | |
| , pytorch | |
| , requests | |
| # Check inputs | |
| , pytorch | |
| , requests |
stale
bot
removed
2.status: stale
Contributor
Author
|
If I remember correctly this is bundled with pytorch now. I'll open a new PR if that is not the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unstable version of the new composable pytorch data loading library.
TODO
I intend to use this at work, however it's not ready to merge. I'm leaving it as a draft PR for the time being:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes