typespeed: fix darwin compatibility#16013
Conversation
|
By analyzing the blame information on this pull request, we identified @auntieNeo, @dezgeg and @pSub to be potential reviewers |
|
Huh, that's strange. I built it successfully on OS X and NixOS before opening the PR. Maybe I had something wrong with my environment? |
pkgs/games/typespeed/default.nix
Outdated
There was a problem hiding this comment.
Can you try if a simple CC=cc works on both? I think it should...
There was a problem hiding this comment.
Huh! I hadn't thought of that, and I will try it.
There was a problem hiding this comment.
Well, it definitely works on OS X!
|
@domenkozar Travis on Linux is still broken from around the time it was last touched by adding the Darwin support. (Looks like |
|
@dezgeg thanks I'll ask travis team. No change was made on our side regarding this. |
|
Let's experiment on #16022 |
3d44ab9 to
487140e
Compare
Motivation for this change
I use nix on OS X, and I like the game.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)