Skip to content

typespeed: fix darwin compatibility#16013

Merged
dezgeg merged 1 commit intoNixOS:masterfrom
nicknovitski:typespeed-darwin
Jun 9, 2016
Merged

typespeed: fix darwin compatibility#16013
dezgeg merged 1 commit intoNixOS:masterfrom
nicknovitski:typespeed-darwin

Conversation

@nicknovitski
Copy link
Contributor

Motivation for this change

I use nix on OS X, and I like the game.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @auntieNeo, @dezgeg and @pSub to be potential reviewers

@nicknovitski
Copy link
Contributor Author

Huh, that's strange. I built it successfully on OS X and NixOS before opening the PR. Maybe I had something wrong with my environment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try if a simple CC=cc works on both? I think it should...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh! I hadn't thought of that, and I will try it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it definitely works on OS X!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great!

@dezgeg
Copy link
Contributor

dezgeg commented Jun 6, 2016

@domenkozar Travis on Linux is still broken from around the time it was last touched by adding the Darwin support. (Looks like /tmp is now noexec or something). Please investigate.

@domenkozar
Copy link
Member

@dezgeg thanks I'll ask travis team. No change was made on our side regarding this.

@domenkozar
Copy link
Member

Let's experiment on #16022

@domenkozar domenkozar closed this Jun 6, 2016
@domenkozar domenkozar reopened this Jun 6, 2016
@dezgeg dezgeg merged commit a357edc into NixOS:master Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants