pktgen: build with the same CFLAGS as dpdk#15962
Merged
domenkozar merged 1 commit intoNixOS:masterfrom Jun 8, 2016
abuibrahim:master
Merged
pktgen: build with the same CFLAGS as dpdk#15962domenkozar merged 1 commit intoNixOS:masterfrom abuibrahim:master
domenkozar merged 1 commit intoNixOS:masterfrom
abuibrahim:master
Conversation
7 tasks
Contributor
|
cc @domenkozar |
Contributor
Author
|
@domenkozar, this was a separate PR on master, which haven't been merged yet. |
Contributor
|
Why close it? |
Contributor
Author
|
Wait, did I close it? My bad. I did another rebase and force pushed. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unbreak the master build failure https://hydra.nixos.org/build/36613719
pktgen requires SSE3 instructions - same as DPDK.
Interestingly build wasn't failing on release-16.03 with gcc-4.9.3 but fails with gcc-5.3.0.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)