Skip to content

polkadot: handle version without leaveDotGit #159335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asymmetric wants to merge 1 commit into from
Closed

polkadot: handle version without leaveDotGit #159335

asymmetric wants to merge 1 commit into from

Conversation

@asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Feb 11, 2022 •
edited
Loading

Leaving the .git directory around results in reproducibility
issues0.

Kudos to @NobbZ for the hint.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@asymmetric
Copy link
Contributor Author

asymmetric commented Feb 11, 2022

/cc @andresilva re: #159279

@asymmetric
polkadot: handle version without leaveDotGit
08b804d 
Leaving the `.git` directory around results in reproducibility
issues[0].

[0]: NixOS#8567
@asymmetric
Copy link
Contributor Author

asymmetric commented Feb 11, 2022

Sorry, this is actually a stupid idea I applied for a flake, but won't work in this scenario.

@asymmetric asymmetric closed this Feb 11, 2022
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@akru akru Awaiting requested review from akru

@andresilva andresilva Awaiting requested review from andresilva

@FlorianFranzen FlorianFranzen Awaiting requested review from FlorianFranzen

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asymmetric