Skip to content

python3Packages.remarshal: fix build#159159

Closed
jyooru wants to merge 1 commit intoNixOS:masterfrom
jyooru:fix/remarshal
Closed

python3Packages.remarshal: fix build#159159
jyooru wants to merge 1 commit intoNixOS:masterfrom
jyooru:fix/remarshal

Conversation

@jyooru
Copy link
Member

@jyooru jyooru commented Feb 11, 2022

Motivation for this change

Starship depends on this.

Remarshal fails to build due to TOML Kit's version going above what is allowed in pyproject.toml.

Nothing looks too major, so allow all versions of TOML Kit.

https://github.com/sdispater/tomlkit/releases/tag/0.8.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Remarshal fails to build due to TOML Kit's version going above what is allowed in pyproject.toml.

Nothing looks too major, so allow all versions of TOML Kit.

https://github.com/sdispater/tomlkit/releases/tag/0.8.0
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 11, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 11, 2022
@zowoq
Copy link
Contributor

zowoq commented Feb 11, 2022

Fixed in #159074, thanks anyway for the PR.

@zowoq zowoq closed this Feb 11, 2022
@jyooru jyooru deleted the fix/remarshal branch February 11, 2022 07:20
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/whats-an-easy-way-to-check-whether-a-commit-has-been-published-to-a-channel/17720/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants