Skip to content

Comments

python3Packages.jax: 0.2.28 -> 0.3.0#159099

Merged
samuela merged 3 commits intoNixOS:masterfrom
samuela:upkeep-bot/python3Packages.jax-0.3.0-1644540822
Feb 14, 2022
Merged

python3Packages.jax: 0.2.28 -> 0.3.0#159099
samuela merged 3 commits intoNixOS:masterfrom
samuela:upkeep-bot/python3Packages.jax-0.3.0-1644540822

Conversation

@samuela
Copy link
Member

@samuela samuela commented Feb 11, 2022

Motivation for this change

Upgrades python3Packages.jax from 0.2.28 to 0.3.0

This PR was automatically generated by nixpkgs-upkeep.

  • CI workflow that created this PR.
  • Internal tag: 42ab84d8819d796e64f8234cb79e6347.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 11, 2022
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 11, 2022
@samuela samuela mentioned this pull request Feb 11, 2022
Closed
@samuela
Copy link
Member Author

samuela commented Feb 11, 2022

Currently blocked on cgarciae/treeo#7, but maybe we should just patch around that.

jaxlib (https://github.com/google/jax/releases/tag/jaxlib-v0.3.0) will also need to be upgraded manually

@samuela
Copy link
Member Author

samuela commented Feb 11, 2022

currently blocked on jax-ml/jax#9534

@ofborg ofborg bot requested a review from ndl February 11, 2022 23:08
@samuela
Copy link
Member Author

samuela commented Feb 12, 2022

Result of nixpkgs-review pr 159099 run on x86_64-linux 1

1 package failed to build:
  • python39Packages.elegy
18 packages built:
  • python310Packages.chex
  • python310Packages.jax
  • python310Packages.jaxlib (python310Packages.jaxlib-build ,python310Packages.jaxlibWithoutCuda)
  • python310Packages.jaxlibWithCuda
  • python310Packages.jmp
  • python310Packages.treeo
  • python39Packages.chex
  • python39Packages.dm-haiku
  • python39Packages.flax
  • python39Packages.jax
  • python39Packages.jaxlib (python39Packages.jaxlib-build ,python39Packages.jaxlibWithoutCuda)
  • python39Packages.jaxlib-bin
  • python39Packages.jaxlibWithCuda
  • python39Packages.jmp
  • python39Packages.objax
  • python39Packages.optax
  • python39Packages.treeo
  • python39Packages.treex

@samuela
Copy link
Member Author

samuela commented Feb 12, 2022

elegy failure is unrelated:

builder for '/nix/store/anxmyb0011g41krphyxb5jidl9rvarn9-python3.9-elegy-0.8.4.drv' failed with exit code 1; last 10 log lines:
  Successfully built elegy
  Finished creating a wheel...
  Finished executing pipBuildPhase
  installing
  Executing pipInstallPhase
  /build/source/dist /build/source
  Processing ./elegy-0.8.4-py3-none-any.whl
  Requirement already satisfied: tensorboardx<3.0,>=2.1 in /nix/store/vfpnjl9hnrlpd5pf90ibp5zavywm7pqi-python3.9-tensorboardx-2.4/lib/python3.9/site-packages (from elegy==0.8.4) (2.4)
  ERROR: Could not find a version that satisfies the requirement cloudpickle<2.0.0,>=1.5.0 (from elegy) (from versions: none)
  ERROR: No matching distribution found for cloudpickle<2.0.0,>=1.5.0
cannot build derivation '/nix/store/2shnhq0f7cxx7gk4f8fjxqasbm82vpql-review-shell.drv': 1 dependencies couldn't be built

This PR is ready for review.

@samuela
Copy link
Member Author

samuela commented Feb 12, 2022 •
edited
Loading

elegy failure is now tracked: #159456

@samuela
Copy link
Member Author

samuela commented Feb 12, 2022

absent a review, I'll merge tomorrow unless anyone objects

ndl
ndl reviewed Feb 12, 2022
View reviewed changes
Copy link
Contributor

@ndl ndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall SG but pinning protobuf version might potentially be problematic, see the inline comment.

@samuela
Copy link
Member Author

samuela commented Feb 14, 2022

With f375338 we are now building against protobuf instead of protobuf3_12. An interesting note about that commit: fetchAttrs hashes had to be updated for the CPU version, but not for the GPU version for some reason. Either way, both versions build just fine now.

I'll go ahead and squash and merge tomorrow unless anyone objects!

@ofborg ofborg bot requested a review from ndl February 14, 2022 05:28
ndl
ndl reviewed Feb 14, 2022
View reviewed changes
pkgs/development/python-modules/treeo/default.nix Outdated
Copy link
Contributor

@ndl ndl Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is fetchpatch needed? It doesn't seem to be used?

ndl
ndl reviewed Feb 14, 2022
View reviewed changes
pkgs/development/python-modules/treeo/default.nix Outdated
Copy link
Contributor

@ndl ndl Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #159933 do we need this change in this PR?

Copy link
Member Author

@samuela samuela Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can skip it in this pr if you'd prefer. I just wanted to make everything go green, but I'm happy if #159933 looks good to you

Copy link
Contributor

@ndl ndl Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment on #159933, I suggest we unbundle treeo versioning issue and deal with it in that separate PR so that you can go ahead and merge this one?

ndl
ndl approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@ndl ndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for spending the time on fixing the protobuf versioning situation!

I have just one extra question RE: treeo change (sorry, didn't notice it before - we might want to skip it given #159933) but otherwise LGTM.

@samuela samuela mentioned this pull request Feb 14, 2022
Closed
@samuela samuela force-pushed the upkeep-bot/python3Packages.jax-0.3.0-1644540822 branch from f375338 to e663c60 Compare February 14, 2022 21:41
@samuela
Copy link
Member Author

samuela commented Feb 14, 2022

@ndl ok just force pushed new commits to upgrade jax, jaxlib, jaxlib-bin but avoid touching treeo. Do those commits look ok to you?

@ndl
Copy link
Contributor

ndl commented Feb 14, 2022

@samuela yes, the current set of changes LGTM, thank you!

@samuela
Copy link
Member Author

samuela commented Feb 14, 2022

ok great, thanks for all your help @ndl! merging now...

@samuela samuela merged commit b0f0668 into NixOS:master Feb 14, 2022
@samuela samuela deleted the upkeep-bot/python3Packages.jax-0.3.0-1644540822 branch February 14, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

1 more reviewer

@ndl ndl ndl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuela @ndl