wlgreet: 0.3 -> 2022-01-25

[brandonweeks]

Motivation for this change

wlgreet is broken on wlroots 0.15.5 or later (#151234) due to a protocol negotiation bug in wlgreet. The bug has been fixed upstream in 8517e57.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[brandonweeks]

/cc @primeos

[primeos]

Thanks for the fix :)

According to our guidelines (https://nixos.org/manual/nixpkgs/unstable/#sec-package-naming) we should append -unstable to pname (not version) and the commit message should also use the date in the subject wlgreet: 0.3 -> 2022-01-25.

IMO it'd also be nice if you could include the PR's description in the commit message (the commit message should be the most important and GitHub can serve for discussions, etc. - plus if you put it in the commit message before opening the PR GitHub will insert the commit message's body for you).

Anyway, this is more of a nitpick (I'm not sure how strictly we enforce those rules) but it'd be nice if you could follow them in the future.

But other than that, consider this a +1 from me.
@luc65r are you also fine with this change?

[brandonweeks]

pname and commit message. Thank you for the feedback @primeos.