FFmpeg 5.0 build fixes#158226
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
vcunat
requested review from
Ericson2314,
Mic92,
aszlig,
kalbasit and
zowoq
as code owners
github-actions
bot
added
6.topic: golang
github-actions
bot
removed
6.topic: golang
|
This should be based on |
|
Yeah, my bad. Fixed. |
ofborg
bot
added
10.rebuild-darwin: 501+
ofborg
bot
added
10.rebuild-darwin: 1-10
ofborg
bot
added
the
8.has: clean-up
|
Result of 3 packages failed to build:
|
An error of x265: |
|
Just confirmed, once x265 build is fixed, all |
Needed for FFmpeg 5 compatibility. Upstream hasn't tagged a release since 2019.
Needed for FFmpeg 5.0 compatibility. Last release was in 2019.
Is broken and long-abandoned by upstream.
Temporary to not break its dependencies. See NixOS#154347 (comment)
|
Result of 12 packages built:
|
| gmailieer = lieer; # Added 2020-04-19 | ||
| gmic_krita_qt = gmic-qt-krita; # Added 2019-09-07 | ||
| gmvault = throw "gmvault has been removed because it is unmaintained, mostly broken, and insecure"; # Added 2021-03-08 | ||
| gnash = throw "gnash has been removed; broken and abandoned upstream."; # added 2022-02-06 |
There was a problem hiding this comment.
- It's not broken:
λ git revert 79cb125a6d27f3846cd2e60ae71926de95bae78b
Auto-merging pkgs/top-level/all-packages.nix
Auto-merging pkgs/top-level/aliases.nix
[master 79247e69dc6] Revert "gnash: remove"
4 files changed, 193 insertions(+), 1 deletion(-)
create mode 100644 pkgs/misc/gnash/0001-fix-build-with-ffmepg-4.patch
create mode 100644 pkgs/misc/gnash/default.nix
λ nix build -f. gnash
[1 built, 300 copied (1193.3 MiB), 250.5 MiB DL]
-
It's not broken because several people are making patches, despite being unmaintained upstream.
-
You shouldn't just remove packages without pinging their maintainers.
There was a problem hiding this comment.
The switch of ffmpeg default was reverted later, so I assume that's why it isn't broken now.
There was a problem hiding this comment.
- It's not broken:
Like @vcunat said, it was broken with ffmpeg 5. That was reverted, so of course it's not broken anymore.
λ git revert 79cb125a6d27f3846cd2e60ae71926de95bae78b Auto-merging pkgs/top-level/all-packages.nix Auto-merging pkgs/top-level/aliases.nix [master 79247e69dc6] Revert "gnash: remove" 4 files changed, 193 insertions(+), 1 deletion(-) create mode 100644 pkgs/misc/gnash/0001-fix-build-with-ffmepg-4.patch create mode 100644 pkgs/misc/gnash/default.nix λ nix build -f. gnash [1 built, 300 copied (1193.3 MiB), 250.5 MiB DL]2. It's not broken because several people are making patches, despite being unmaintained upstream.
Where? The most recent patch on the gnash-dev mailing list is a fix for building with ffmpeg 4 - look who the author is... Also, I checked upstream before removing it.
3. You shouldn't just remove packages without pinging their maintainers.
This is your only valid criticism, I didn't realise ofborg wouldn't ping maintainers when their package is removed. I'll be sure to check next time.
There was a problem hiding this comment.
The switch of ffmpeg default was reverted later
Ah, I see.
Where? The most recent patch on the gnash-dev mailing list is a fix for building with ffmpeg 4 - look who the author is... Also, I checked upstream before removing it.
I guess I'll have to thank you. The package is on life support, but it's still useful, so
unless it's really impossible to compile with libraries in Nixpkgs I'd rather keep it alive.
I'll be sure to check next time.
Ok, Thank you.
5 participants
Motivation for this change
Updating applications for FFmpeg 5.0.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes