Consume self-deploy's startAt attribute#157883
Conversation
tazjin
left a comment
There was a problem hiding this comment.
commit message should be changed to something like nixos/self-deploy: .... bla ...
As NixOS#157879 points-out, this attribute appears unused. Fixes NixOS#157879
|
Good catch! Must have missed it when I rewrote the service for nixpkgs. I admit I'm happy to see actual use of the self-deploy service in the wild -- I've meant to write a blog post about it for ages but have never gotten around to it. All looks good to me. My personal preferences would prefer |
|
Looking back on the code, it may also be worthwhile to make the minor change of gating the service's systemd dependency on |
As recommended in the discussion at NixOS#157883
As recommended in the discussion at NixOS#157883
As recommended in the discussion at #157883
As recommended in the discussion at NixOS#157883
As recommended in the discussion at NixOS#157883
As recommended in the discussion at NixOS#157883
As recommended in the discussion at NixOS#157883
As #157879 points-out, this attribute appears unused.
Fixes #157879