hdrmerge: init at unstable-2020-11-12#157087
Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom Mar 8, 2022
Merged
Conversation
muscaln
approved these changes
Jan 28, 2022
paperdigits
force-pushed
the
pkg-hdrmerge
branch
from
ac908e7 to
9720c47
Compare
muscaln
suggested changes
Jan 29, 2022
paperdigits
force-pushed
the
pkg-hdrmerge
branch
from
6f30a08 to
aa1cadc
Compare
Contributor
Author
|
@muscaln thanks, I've made all your changes and squashed the commits. |
ckiee
suggested changes
Mar 1, 2022
Member
ckiee
left a comment
ckiee
left a comment
There was a problem hiding this comment.
The hdrmerge commit message should say hdrmerge: init at unstable-2020-11-12. Also this was a bit rushed since I have to go now.
Member
|
Ofborg eval fail: |
ckiee
reviewed
Mar 1, 2022
paperdigits
force-pushed
the
pkg-hdrmerge
branch
2 times, most recently
from
4709048 to
36dc02f
Compare
ofborg
bot
added
8.has: package (new)
Contributor
Author
|
Thanks @ckiee ! |
ckiee
suggested changes
Mar 2, 2022
paperdigits
force-pushed
the
pkg-hdrmerge
branch
from
316eae4 to
0fd8c0a
Compare
Contributor
Author
|
Thanks @ckiee -- this is the one, I can feel it! |
SuperSandro2000
changed the title
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
The second commit contains twice hdrmerge: .
paperdigits
force-pushed
the
pkg-hdrmerge
branch
from
f8739d8 to
07f1a62
Compare
paperdigits
force-pushed
the
pkg-hdrmerge
branch
from
07f1a62 to
15a542c
Compare
ofborg
bot
removed
the
10.rebuild-linux: 1
Contributor
Author
|
@SuperSandro2000 thanks! I've made the requested changes. |
paperdigits
force-pushed
the
pkg-hdrmerge
branch
from
0723629 to
a16ef8d
Compare
paperdigits
force-pushed
the
pkg-hdrmerge
branch
from
a16ef8d to
c3acc1e
Compare
SuperSandro2000
approved these changes
Mar 8, 2022
Member
|
No rebase for the squash+message amend? |
Member
we could definitely do that but I want to get this merged so I am a bit lazy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To package this application.
Based on the flake package by @mkroehnert at https://codeberg.org/mkroehnert/nix-flakes/src/branch/hdrmerge-latest
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes