Skip to content

Comments

idea: set StartupWMClass on desktop item#15685

Merged
joachifm merged 1 commit intoNixOS:masterfrom
chris-martin:idea-wmClass
May 27, 2016
Merged

idea: set StartupWMClass on desktop item#15685
joachifm merged 1 commit intoNixOS:masterfrom
chris-martin:idea-wmClass

Conversation

@chris-martin
Copy link
Contributor

@chris-martin chris-martin commented May 25, 2016

Motivation for this change

Idea products don't currently play well with the Gnome 3 launcher, as demonstrated by the screenshot, where the Intellij icon shows up twice instead of once.

screenshot from 2016-05-24 22-52-02

The fix is to set StartupWMClass in the desktop entry file.

I looked up the code that generates the wm class, ran each product to verify the names with xprop, and installed idea15-ultimate into my profile to test that the result fixes the issue.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This makes all Idea product behave nicely with the Gnome launcher.

The WM class for every Idea product is in the form

    jetbrains-<product>[-ce]

Where <product> is e.g. "idea", "pycharm", etc., and "-ce" is appended
for community editions.
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @edwtjo, @baldo and @gebner to be potential reviewers

@joachifm joachifm added the 0.kind: enhancement Add something new or improve an existing system. label May 25, 2016
@joachifm joachifm merged commit 0eaea88 into NixOS:master May 27, 2016
@chris-martin chris-martin deleted the idea-wmClass branch May 27, 2016 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: enhancement Add something new or improve an existing system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants