[staging-next] Fix meson builds by ncfavier · Pull Request #156192 · NixOS/nixpkgs

ncfavier · 2022-01-22T18:45:45Z

The update to meson 0.60 made some warnings become errors. This fixes all the meson build errors I could find in https://hydra.nixos.org/eval/1739607?filter=x86_64-linux&compare=1739453&full=#tabs-now-fail (except urbit which is nontrivial and needs an update anyway).

pkgs/applications/audio/mpc/default.nix

Adds upstream patch from MusicPlayerDaemon/mpc#76 to make the dependency on rsync optional.

Adds upstream patch from letoram/xarcan@b67e514 to remove the warnings (which are now errors)

Adds upstream patch from getting-things-gnome/gtg#729 to fix the error about unknown keyword arguments

Fixes the build with meson 0.60. The option was renamed in hexchat/hexchat@cbb0927

Adds upstream patch from https://github.com/freedesktop/xorg-intel-gpu-tools/commit/963917a3565466832a3b2fc22e9285d34a0bf944

Fixes build with meson 0.60

libfprint 1.90.7 doesn't support the udev_rules_dir build option

pkgs/development/libraries/libhttpseverywhere/default.nix

Adds patch from https://gitlab.gnome.org/GNOME/libhttpseverywhere/-/merge_requests/1

Fixes build with meson 0.60. The libreoffice extension was moved to its own repository in gkarsay/parlatype@14386d2 so there's no need to disable it.

Adds upstream patch from https://gitlab.gnome.org/GNOME/retro-gtk/-/merge_requests/167

Fixes the build with meson 0.60. The option was removed in Genymobile/scrcpy@eb34098

Fixes the build with meson 0.60. Options were renamed to lower case in marzer/tomlplusplus@1381240 and build_tests and build_examples are now disabled when tomlplusplus is used as a subproject.

Feature flags were renamed in zrythm/zrythm@2f6ca07 and the ffmpeg dependency was dropped in zrythm/zrythm@116b955

ncfavier · 2022-01-22T20:03:30Z

What's up with ofborg?

Ignorable calculation error:
DeserializeError(Error("EOF while parsing a value", line: 1, column: 0))

ncfavier · 2022-01-22T20:09:38Z

I think I know what's wrong: algorith (mpc maintainer) doesn't have a github field.

ncfavier · 2022-01-22T21:03:12Z

Ofborg really doesn't want to work today.
@ofborg build mpc_cli arcan.xarcan gtg hexchat intel-gpu-tools iptsd lipfprint-tod libhttpseverywhere parlatype retro-gtk scrcpy yabridge zrythm

ncfavier · 2022-01-22T21:12:42Z

I could only add 15 reviewers so ping @pSub @maxeaubrey @msfjarvis @kira-bruneau @oyren @hedning @DriesVanDaele

dasJ · 2022-01-22T21:16:00Z

Maybe that limitation is for the best? 👀

mweinelt · 2022-01-23T01:52:09Z

Maybe that limitation is for the best? 👀

True for most repos, not for us though.

ncfavier · 2022-01-23T01:55:13Z

Just noticed The following builds were skipped because they don't evaluate on x86_64-linux: lipfprint-tod. Not sure why, builds fine locally.

...ah, that would be because I typed lip instead of lip (EDIT: oh my god fingers come on) 🙃
@ofborg build libfprint-tod

mweinelt · 2022-01-23T02:30:39Z

Result of nixpkgs-review pr 156192 run on x86_64-linux 1

19 packages built:

arcan.xarcan
clerk
driversi686Linux.vaapiIntel
fprintd-tod
gtg
hexchat
intel-gpu-tools
iptsd
libfprint-2-tod1-goodix
libfprint-2-tod1-vfs0090
libfprint-tod
libhttpseverywhere
mpc_cli
parlatype
retro-gtk
scrcpy
vaapiIntel
yabridge
zrythm

mweinelt · 2022-01-23T02:31:12Z

The maintainer fixup should probably be its own commit.

pkgs/misc/scrcpy/default.nix

magnetophon

I built and ran zrythm.

vcunat · 2022-01-24T08:19:19Z

urbit is nontrivial and needs an update anyway

/cc maintainer @laMudri; example failure: https://hydra.nixos.org/build/164587286

laMudri · 2022-01-27T08:45:15Z

I haven't used urbit for years, so I can't offer any particular insight.

ncfavier force-pushed the fix-meson-builds branch from d65a980 to e7798c8 Compare January 22, 2022 18:50

ncfavier mentioned this pull request Jan 22, 2022

Staging next 2022-01-12 #154708

Merged

vcunat requested changes Jan 22, 2022

View reviewed changes

pkgs/applications/audio/mpc/default.nix Outdated Show resolved Hide resolved

ncfavier added 7 commits January 22, 2022 20:13

mpc_cli: fix build with meson 0.60

e2686f5

Adds upstream patch from MusicPlayerDaemon/mpc#76 to make the dependency on rsync optional.

arcan.xarcan: fix build with meson 0.60

b5c610b

Adds upstream patch from letoram/xarcan@b67e514 to remove the warnings (which are now errors)

gtg: fix build with meson 0.60

3026e3d

Adds upstream patch from getting-things-gnome/gtg#729 to fix the error about unknown keyword arguments

hexchat: rename with-text option to text-frontend

49c8514

Fixes the build with meson 0.60. The option was renamed in hexchat/hexchat@cbb0927

intel-gpu-tools: fix build with meson 0.60

49d7624

Adds upstream patch from https://github.com/freedesktop/xorg-intel-gpu-tools/commit/963917a3565466832a3b2fc22e9285d34a0bf944

iptsd: rename systemd build option to service_manager=systemd

4068bcb

Fixes build with meson 0.60

libfprint-tod: fix build with meson 0.60

9ab8b14

libfprint 1.90.7 doesn't support the udev_rules_dir build option

ncfavier force-pushed the fix-meson-builds branch from e7798c8 to d318610 Compare January 22, 2022 19:18

SuperSandro2000 reviewed Jan 22, 2022

View reviewed changes

pkgs/development/libraries/libhttpseverywhere/default.nix Outdated Show resolved Hide resolved

ncfavier added 6 commits January 22, 2022 20:28

libhttpseverywhere: fix build with meson 0.60

7d97b7d

Adds patch from https://gitlab.gnome.org/GNOME/libhttpseverywhere/-/merge_requests/1

parlatype: remove libreoffice build option

5276d5f

Fixes build with meson 0.60. The libreoffice extension was moved to its own repository in gkarsay/parlatype@14386d2 so there's no need to disable it.

retro-gtk: fix build with meson 0.60

915e4a0

Adds upstream patch from https://gitlab.gnome.org/GNOME/retro-gtk/-/merge_requests/167

scrcpy: remove unknown override_server_path option

d251bc5

Fixes the build with meson 0.60. The option was removed in Genymobile/scrcpy@eb34098

yabridge: fix meson options

c5d5217

Fixes the build with meson 0.60. Options were renamed to lower case in marzer/tomlplusplus@1381240 and build_tests and build_examples are now disabled when tomlplusplus is used as a subproject.

zrythm: fix build with meson 0.60

1a6f79a

Feature flags were renamed in zrythm/zrythm@2f6ca07 and the ffmpeg dependency was dropped in zrythm/zrythm@116b955

ncfavier force-pushed the fix-meson-builds branch from d318610 to 1a6f79a Compare January 22, 2022 19:28

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 22, 2022

ncfavier force-pushed the fix-meson-builds branch from 5c189cc to 65a898d Compare January 22, 2022 20:19

vcunat self-requested a review January 22, 2022 20:22

ncfavier force-pushed the fix-meson-builds branch from 65a898d to 223fa82 Compare January 22, 2022 20:26

ncfavier requested review from magnetophon, melchips and tomberek January 22, 2022 21:10

ncfavier requested review from AndersonTorres, DamienCassou, DeltaEvo, dasJ, grahamc, jtojnar, lukeadams, romildo, sternenseemann and tshaynik January 22, 2022 21:10

ncfavier added 2 commits January 23, 2022 03:33

maintainers: add github handle for algorith

44d1600

mpc_cli: add ncfavier as maintainer

d1ad218

ncfavier force-pushed the fix-meson-builds branch from 223fa82 to d1ad218 Compare January 23, 2022 02:33

jtojnar reviewed Jan 23, 2022

View reviewed changes

pkgs/misc/scrcpy/default.nix Show resolved Hide resolved

vcunat approved these changes Jan 23, 2022

View reviewed changes

DeltaEvo approved these changes Jan 23, 2022

View reviewed changes

magnetophon approved these changes Jan 23, 2022

View reviewed changes

mweinelt merged commit 98870a6 into NixOS:staging-next Jan 23, 2022

ncfavier deleted the fix-meson-builds branch January 23, 2022 15:01

Uh oh!

Comments

Conversation

ncfavier commented Jan 22, 2022

Uh oh!

Uh oh!

Uh oh!

ncfavier commented Jan 22, 2022

Uh oh!

ncfavier commented Jan 22, 2022

Uh oh!

ncfavier commented Jan 22, 2022

Uh oh!

ncfavier commented Jan 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dasJ commented Jan 22, 2022

Uh oh!

mweinelt commented Jan 23, 2022

Uh oh!

ncfavier commented Jan 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mweinelt commented Jan 23, 2022

Uh oh!

mweinelt commented Jan 23, 2022

Uh oh!

Uh oh!

magnetophon left a comment

Choose a reason for hiding this comment

Uh oh!

vcunat commented Jan 24, 2022

Uh oh!

laMudri commented Jan 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ncfavier commented Jan 22, 2022 •

edited

Loading

ncfavier commented Jan 23, 2022 •

edited

Loading