Merged
Conversation
bukuserver (an optional web GUI frontend for buku) depends on a large number of flask packages, which break in nixpkgs very often.
Comment on lines
55
to
+58
| flake8 | ||
| pyyaml | ||
| mypy-extensions | ||
| click |
Member
There was a problem hiding this comment.
pytest-cov, pylint and flake8 should be removed. They only check cosmetic stuff and often break for no good reason.
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
No, never really did, I just noticed the broken package when checking out buku at the time. I agree with this change. |
Ma27
approved these changes
Jan 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
bukuserver (an optional web GUI frontend for buku) depends on a large number of flask packages, which break in nixpkgs very often - I've been forced to remove buku from my system closure at least a couple times a year at this point, even though I have no use for this web interface. It currently does not build, which means buku cannot be used at all.
Once #156188 (or something similar that fixes flask-admin) is landed, it will at least build and can be turned back on by default - though with buku being primarily a command-line tool (plus optional browser extensions that can serve as an interface too), it seems unlikely that a majority of users even use this interface to begin with? We could also maybe consider adding
pkgs.bukuserverrather than building them both together.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notescc @dermetfan, do you still use this?