nixos/redis: fix port option#156004
Merged
symphorien merged 1 commit intoNixOS:masterfrom Jan 22, 2022
Merged
Conversation
14 tasks
danth
reviewed
Jan 21, 2022
Member
|
Please check the eval-error, it seems to be related to your changes. |
ncfavier
requested changes
Jan 21, 2022
Contributor
Author
|
Sorry for the brain-dead typo (evolving in a degraded work environment for a few months..) |
Member
|
The |
ncfavier
approved these changes
Jan 21, 2022
Contributor
Author
|
@ncfavier, oh sorry, so it was not only a brain-dead typo, but also a semantic change that was not obvious to me. |
lunik1
approved these changes
Jan 22, 2022
Member
|
@GrahamcOfBorg test redis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#142635 (comment)
Things done
bindisnull.sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesPing @lunik1.