Closed
Conversation
A means of transforming default values.
13 tasks
Member
Author
|
Closing, because while this is a better solution than #157070, it moves the module system in the wrong direction. See #157070 (comment) |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/natural-deduction-rules-for-the-nixos-module-merge/26513/6 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow configs to transform defaults by means of a function, allow "mkForce" to transform regular configs.
Draft because of remaining questions:
Is this something we want or a symptom of bad module design?
Should
mkTransformproduce anoverrideor its own type? Is it ok to peek inside amkForcevalue to look for atransformobject, or would that be too strict?What is the performance impact?
TODO (assuming boring answers to the questions):
mkForcePriorityetccc @infinisil
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes