live555: 2019.11.22 -> 2022.01.21

[FliegendeWurst]

Motivation for this change

Fix #138686.

Things done

Tested that playing RTSP streams in VLC still works.

• Built on platform(s)
  • x86_64-linux
• Tested compilation of packages that depend on this change: live555 and vlc
• Tested basic functionality of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

[AndersonTorres]

Split the commit into two: one for the paches on VLC, the other for the live555 upgrade.

[risicle]

On macos 10.15:

configuring
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
cat: config.macosx: No such file or directory
@nix { "action": "setPhase", "phase": "buildPhase" }
building
build flags: -j8 -l8 SHELL=/nix/store/b0q4wjdw6xwhfsqy8ab106cmhn5xrr8p-bash-5.1-p12/bin/bash
cd liveMedia ; make
make[1]: Entering directory '/private/tmp/nix-build-live555-2022.01.17.drv-0/live/liveMedia'
make[1]: *** No rule to make target 'Media.', needed by 'libliveMedia.'.  Stop.
make[1]: Leaving directory '/private/tmp/nix-build-live555-2022.01.17.drv-0/live/liveMedia'
make: *** [Makefile:18: all] Error 2

[risicle]

This just needs

x86_64-darwin = "macosx";

replaced with

x86_64-darwin = "macosx-catalina";

to fix. This is the earliest release the source has a config for, and probably has the best hope of working back to 10.12.

p.s. try reading http://www.live555.com/liveMedia/faq.html and see how far you get before your head explodes - particularly the section "Questions about the libraries' source code"

[FliegendeWurst]

Thanks for the hint, let's hope it builds now..

[AndersonTorres]

I will wait ofborg a little bit more.

[github-actions]

Successfully created backport PR #156834 for release-21.11.

[ajs124]

This breaks the libvlc build. How was this tested? Why was this backported?

[codygman]

This breaks the libvlc build. How was this tested? Why was this backported?

I was just affected by this while trying to upgrade because of pwnkit CVE-2021-4034 (PR: #156750 )

I found some clues in the commit and the linked issue:

Ipv6 support has been added to live 555 in version 2021.02.11 and vlc 3.0.12 (and vlc 4) fail to build with this error :

So I think because newer versions of vlc don't build without these patches?

Maybe I'm skimming too quickly, but perhaps one of the concerns on that bug was correct:

Dominic108 @dominic108 · 9 months ago

In Ubuntu, -lssl and -lcrypto both come in the libssl-dev package for openssl. However, in a second thought, I am not sure adding -lssl and -lcrypto directly in Makefile.am is the most robust way to proceed. - source

[mweinelt]

This broke plasma and thereby became a channel blocker, that was also backported. How was this tested?