Skip to content

python310Packages.furo: 2021.10.9 -> 2022.1.2#155717

Closed
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/python310Packages.furo
Closed

python310Packages.furo: 2021.10.9 -> 2022.1.2#155717
r-ryantm wants to merge 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/python310Packages.furo

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python310Packages.furo is: "A clean customizable documentation theme for Sphinx"

meta.homepage for python310Packages.furo is: "https://github.com/pradyunsg/furo"

meta.changelog for python310Packages.furo is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 2022.1.2 with grep in /nix/store/j7amc6z7qbhwwa0bldrh39dvsxqdvhs9-python3.10-furo-2022.1.2

  • found 2022.1.2 in filename of file in /nix/store/j7amc6z7qbhwwa0bldrh39dvsxqdvhs9-python3.10-furo-2022.1.2


Rebuild report (if merged into master) (click to expand)
6 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 x86_64-darwin rebuild(s)


First fifty rebuilds by attrpath
kitty
python310Packages.furo
python39Packages.furo
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/j7amc6z7qbhwwa0bldrh39dvsxqdvhs9-python3.10-furo-2022.1.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python310Packages.furo https://github.com/r-ryantm/nixpkgs/archive/d30252e751e99c5a7bea18db2e57f7f19b5ff4b3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/j7amc6z7qbhwwa0bldrh39dvsxqdvhs9-python3.10-furo-2022.1.2
ls -la /nix/store/j7amc6z7qbhwwa0bldrh39dvsxqdvhs9-python3.10-furo-2022.1.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • kitty
2 packages built:
  • python310Packages.furo
  • python39Packages.furo

Maintainer pings

cc @Luflosi for testing.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 19, 2022
@Luflosi
Copy link
Contributor

Luflosi commented Jan 19, 2022

This update breaks furo. Please don't merge.
The directory $out/lib/python3.10/site-packages/furo/theme/furo/static must not be empty but after this update it is. This happens because in order to build these files, furo now depends on webpack-cli but webpack-cli is broken and I couldn't make it work. See #42275 (comment).
To see what breaks in practice when updating furo, try building kitty (not on macOS). kitty's documentation will fail to build.

@ryantm ryantm marked this pull request as draft January 19, 2022 23:00
@smunix
Copy link
Contributor

smunix commented Feb 11, 2022

This update breaks furo. Please don't merge. The directory $out/lib/python3.10/site-packages/furo/theme/furo/static must not be empty but after this update it is. This happens because in order to build these files, furo now depends on webpack-cli but webpack-cli is broken and I couldn't make it work. See #42275 (comment). To see what breaks in practice when updating furo, try building kitty (not on macOS). kitty's documentation will fail to build.

It looks like kitty's documentation is now broken. Has a different PR updating furo been merged? I have this error:

       >   File "/nix/store/13z9v2893iapkj12gk47q04w2197gysq-python3.9-sphinx-4.4.0/lib/python3.9/site-packages/sphinx/events.py", line 109, in emit
       >     raise ExtensionError(__("Handler %r for event %r threw an exception") %                                                      
       > sphinx.errors.ExtensionError: Handler <function _html_page_context at 0x7ffff3218c10> for event 'html-page-context' threw an exception (exception: [Errno 2] No such file or directory: '/nix/store/pppq4jc77qw9qv4rqghqa32rjdm314hq-python3.9-furo-2022.1.2/lib/python3.9/s
ite-packages/furo/theme/furo/static/styles/furo.css')                                                                                     
       >                                         
       > Extension error (furo):                    
       > Handler <function _html_page_context at 0x7ffff3218c10> for event 'html-page-context' threw an exception (exception: [Errno 2] No such file or directory: '/nix/store/pppq4jc77qw9qv4rqghqa32rjdm314hq-python3.9-furo-2022.1.2/lib/python3.9/site-packages/furo/theme/furo/s
tatic/styles/furo.css')                    
       > make[1]: *** [Makefile:24: html] Error 2                                                                                                                                                                                                                                    

@smunix
Copy link
Contributor

smunix commented Feb 11, 2022

It looks like kitty's documentation is now broken. Has a different PR updating furo been merged? I have this error:

Here, furo was updated to 2022

@Luflosi
Copy link
Contributor

Luflosi commented Feb 11, 2022

Yes, it was updated in 7b890d5.
The commit should be reverted or someone needs to fix webpack.
Alternatively (but less desirable IMO) we could mark furo as broken and patch kitty to not build the documentation.

@smunix smunix mentioned this pull request Feb 11, 2022
13 tasks
@mweinelt
Copy link
Member

@Luflosi
Copy link
Contributor

Luflosi commented Feb 11, 2022

Closing as the update was merged in 7b890d5 and #159255 will fix the build.

@Luflosi Luflosi closed this Feb 11, 2022
@r-ryantm r-ryantm deleted the auto-update/python310Packages.furo branch February 12, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants