Skip to content

[staging] python3Packages.setuptools: 57.2.0 -> 60.5.0#155531

Closed
jonringer wants to merge 1 commit intoNixOS:stagingfrom
jonringer:bump-setuptools
Closed

[staging] python3Packages.setuptools: 57.2.0 -> 60.5.0#155531
jonringer wants to merge 1 commit intoNixOS:stagingfrom
jonringer:bump-setuptools

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 18, 2022

Motivation for this change

cherry-picked from #154969 (cherry picked from commit 410658a)

Since setuptools removed use_2to3 internal option, many packages were broken.

This doesn't have an "easy" solution, as it usually means that the upstream still has a
significant amount of python2 code, and without vendoring 2to3, there's not easy way for
the package to be installed with python3

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 18, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 19, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FRidh
Copy link
Member

FRidh commented Jan 19, 2022

Why do you want to cherry-pick this to staging? So to keep track of for another time?

@dotlambda dotlambda marked this pull request as draft January 19, 2022 14:06
@jonringer
Copy link
Contributor Author

Why do you want to cherry-pick this to staging? So to keep track of for another time?

it's a mass rebuild. And my server can handle the build load. I can rebase onto master for others

@mweinelt
Copy link
Member

Superseded by #160067

@mweinelt mweinelt closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants