resholve: work around nixpkgs aarch64-darwin issues#155251
Merged
happysalada merged 1 commit intoNixOS:masterfrom Jan 27, 2022
Merged
resholve: work around nixpkgs aarch64-darwin issues#155251happysalada merged 1 commit intoNixOS:masterfrom
happysalada merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
6.topic: darwin
Member
|
Result of 3 packages failed to build:
|
abathur
force-pushed
the
resholve_oildev_workaround
branch
from
9339845 to
014a70c
Compare
ofborg
bot
added
the
11.by: package-maintainer
abathur
force-pushed
the
resholve_oildev_workaround
branch
2 times, most recently
from
d2a23b3 to
bdeb231
Compare
- add an oil-dev patch to work around build failure documented in NixOS#154203 - override configargparse to disable tests and work around failure reported in NixOS#156807
abathur
force-pushed
the
resholve_oildev_workaround
branch
from
bdeb231 to
a0c7e0e
Compare
Member
Author
|
Reopening for review since ofborg aarch64-darwin ran clean. |
abathur
changed the title
Contributor
|
the fix makes sense, and ofborg pass. |
Member
Author
|
I am a bit unsure about the override approach, but if it passes your gut check it is probably fine. :) |
Contributor
|
Like you said, it's a short term fix :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are hopefully both just short-term workarounds.
cc <file> -o /dev/nullfails on aarch64-darwin #154203The OfBorg results should clarify whether this works.