Skip to content

python3Packages.wtforms: 2.3.3 -> 3.0.1#155221

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
gador:wtforms-update
Jan 16, 2022
Merged

python3Packages.wtforms: 2.3.3 -> 3.0.1#155221
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
gador:wtforms-update

Conversation

@gador
Copy link
Member

@gador gador commented Jan 16, 2022

update of wtforms to 3.0.1

Motivation for this change

needed for pgadmin4 init
#154764

Things done
  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)

  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    Several packages break:

    • wtf-peewee: Fix committed upstream, but no new release published
    • flask-admin fails due to a dependency on wtf-peewee
    • buku fails due to flask-admin
    • ihatemoney with ERROR: No matching distribution found for WTForms<2.4,>=2.3.1 Upstream is working on it
    • flask-appbuilder fails and Upstream is working on it
    • apache-airflow fails due to a dependency on flask-appbuilder
  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 22.05 Release Notes (or backporting 21.11 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Maybe we should add wtforms > 3 separately until all breakage is fixed?

I want to add the wtforms>=3 version due to its hard build requirement in pgadmin4.

@gador gador requested review from FRidh and jonringer as code owners January 16, 2022 14:22
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 16, 2022
@gador gador mentioned this pull request Jan 16, 2022
13 tasks
@ofborg ofborg bot requested a review from bhipple January 16, 2022 14:35
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 16, 2022
@gador
Copy link
Member Author

gador commented Jan 16, 2022

Result of nixpkgs-review pr 155221 run on x86_64-linux 1

11 packages failed to build:
  • apache-airflow (python39Packages.apache-airflow)
  • buku
  • python310Packages.apache-airflow
  • python310Packages.flask-admin
  • python310Packages.flask-appbuilder
  • python310Packages.ihatemoney
  • python310Packages.wtf-peewee
  • python39Packages.flask-admin
  • python39Packages.flask-appbuilder
  • python39Packages.ihatemoney
  • python39Packages.wtf-peewee
9 packages built:
  • archivy
  • calibre-web
  • etesync-dav
  • python310Packages.flask-mongoengine
  • python310Packages.flask_wtf
  • python310Packages.wtforms
  • python39Packages.flask-mongoengine
  • python39Packages.flask_wtf
  • python39Packages.wtforms

@SuperSandro2000
Copy link
Member

@symphorien I think you need to add another overwrite to ihatemoney. Sorry about that.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 155221 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:
  • etesync-dav: log was empty
12 packages failed to build and are new build failures:
  • apache-airflow: log was empty
  • (python39Packages.apache-airflow): log was empty
  • buku: log was empty
  • python310Packages.apache-airflow: log was empty
  • python310Packages.flask-admin: log was empty
  • python310Packages.flask-appbuilder: log was empty
  • python310Packages.ihatemoney: log was empty
  • python310Packages.wtf-peewee: log was empty
  • python39Packages.flask-admin: log was empty
  • python39Packages.flask-appbuilder: log was empty
  • python39Packages.ihatemoney: log was empty
  • python39Packages.wtf-peewee: log was empty
8 packages built:
  • archivy
  • calibre-web
  • python310Packages.flask-mongoengine
  • python310Packages.flask_wtf
  • python310Packages.wtforms
  • python39Packages.flask-mongoengine
  • python39Packages.flask_wtf
  • python39Packages.wtforms

@SuperSandro2000 SuperSandro2000 merged commit b1021ac into NixOS:master Jan 16, 2022
@gador gador deleted the wtforms-update branch January 17, 2022 20:41
@arcnmx arcnmx mentioned this pull request Jan 22, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants