Skip to content

Comments

[staging-next] meson: do not update ldconfig cache#155067

Merged
veprbl merged 1 commit intoNixOS:staging-nextfrom
NickCao:meson-ldconfig
Jan 15, 2022
Merged

[staging-next] meson: do not update ldconfig cache#155067
veprbl merged 1 commit intoNixOS:staging-nextfrom
NickCao:meson-ldconfig

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Jan 15, 2022

Motivation for this change

ref: #154833

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@NickCao NickCao changed the title meson: do not update ldconfig cache [staging-next] meson: do not update ldconfig cache Jan 15, 2022
@NickCao NickCao requested a review from jtojnar January 15, 2022 04:06
@ofborg ofborg bot requested a review from AndersonTorres January 15, 2022 04:51
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 15, 2022
jtojnar
jtojnar reviewed Jan 15, 2022
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not suppose it is possible to detect when cross-compilation is occurring and apply the patch only then (to minimize rebuilds)?

If not, we might want to merge any other expensive PRs at the same time.

Otherwise LGTM.

@vcunat
Copy link
Member

vcunat commented Jan 15, 2022

We don't have too many binaries ATM anyway: https://hydra.nixos.org/jobset/nixpkgs/staging-next

@veprbl veprbl merged commit 306d5d2 into NixOS:staging-next Jan 15, 2022
@NickCao NickCao deleted the meson-ldconfig branch January 15, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NickCao @vcunat @jtojnar @veprbl