Make Go packages work with nix-shell#15490
Closed
chris-martin wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
|
By analyzing the blame information on this pull request, we identified @wkennington, @ehmry and @lethalman to be potential reviewers |
Contributor
Author
|
The source has to be in a particular directory hierarchy to satisfy Go. I'm constructing that hierarchy under a temporary directory. I'm not sure if there's a better way to do it - should it going into |
joachifm
added
the
6.topic: golang
chris-martin
changed the title
Contributor
Author
|
@garbas points out to me that this is very similar to the shell hook we use for Python. |
Contributor
|
is this still working after the go packaging rework done recently? |
Contributor
Author
|
I think that refactor obviates this PR, but I'm not sure how to test it. Where did |
Member
|
This works for my local packages #16297 |
7 tasks
Contributor
Author
|
Closing because #16297 seems to be the way to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go projects currently don't work with
nix-shellbecause the source for the project never gets added to$GOPATH. This adds a shell hook to do that.