mariadb: wrap mysqld with --basedir#15421
Conversation
|
By analyzing the blame information on this pull request, we identified @wkennington, @shlevy and @pmahoney to be potential reviewers |
|
Should have mentioned @thoughtpolice as a maintainer. |
|
Hmm, do I understand it right that |
|
It certainly sounds a step forward. Thanks. |
|
Thanks. You'd have to ask @wkennington to be sure, but I think the ideal would be |
|
No, that problem is unavoidable; if libs referred to |
|
@vcunat I haven't been following this whole thing, but FWIW I disagree with the idea that there's no point in splitting outputs that have mutual references. Of course they would both always have to be present, but they wouldn't both have to be, say, included in user environments, processed as buildInputs, etc. Obviously we'd need to extend nix to support the cycle, but I don't think it would be pointless to do so. |
|
Well, yes, there would be some advantages, but I don't think this particular thread was touching this feature that seems not near being implemented in nix. (And I'm personally not convinced the added complexity in nix would be worth it; it seems much easier to e.g. create symlink trees for requested subsets of files.) |
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)This wraps mysqld to always include --basedir set to the nix store location. Without the --basedir argument, mysqld cannot find an error message i18n file, looking in
/not/a/real/dirinstead. This issue specifically affects akonadi from KDE's PIM suite.There is what seems to be a more complete solution in #8494 that seeks to take advantage of multiple-outputs, but that more complex solution is having trouble getting finished or merged (I don't understand some of the discussion). This PR solves the immediate problem and closes #1053. The output splitting fix can come when it's ready.
I've tested this on 16.03 with KDE PIM and a normal mysql service. It seems appropriate to me to merge into release since KDE PIM is currently broken on 16.03, but I'll leave that decision to someone wiser.