Skip to content

Comments

Rename meson_0_60 to meson and update some packages#154172

Merged
alyssais merged 5 commits intoNixOS:stagingfrom
L-as:meson
Jan 11, 2022
Merged

Rename meson_0_60 to meson and update some packages#154172
alyssais merged 5 commits intoNixOS:stagingfrom
L-as:meson

Conversation

@L-as
Copy link
Member

@L-as L-as commented Jan 9, 2022

Motivation for this change

We currently have two mesons. Replaces #144779.

Things done

I do not have enough compute to build this.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. label Jan 9, 2022
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 9, 2022
@AndersonTorres
Copy link
Member

Is this aimed to remove the newer Meson?

@L-as
Copy link
Member Author

L-as commented Jan 9, 2022

This renames meson_0_60 to meson essentially.

@L-as L-as changed the title Remove meson_0_60 and update some packages Rename meson_0_60 to meson and update some packages Jan 9, 2022
@AndersonTorres
Copy link
Member

Well, then 'revert' commits are not needed... or are they?

@L-as
Copy link
Member Author

L-as commented Jan 9, 2022

Those commits are from the previous PR.

@L-as L-as requested review from alyssais and jtojnar January 9, 2022 22:04
@L-as
Copy link
Member Author

L-as commented Jan 10, 2022

Ci passes. Should we merge this?

@L-as L-as requested a review from SuperSandro2000 January 10, 2022 10:30
@AndersonTorres
Copy link
Member

AndersonTorres commented Jan 10, 2022

Those commits are from the previous PR.

Are they needed here? It looks like they can be ignored...

Ci passes. Should we merge this?

Looks like ofborg is complaining.

@L-as
Copy link
Member Author

L-as commented Jan 10, 2022

Are they needed here? It looks like they can be ignored...

Removing them would require rewriting the history.

Looks like ofborg is complaining.

Where? I only see a green checkmark.

@alyssais
Copy link
Member

Removing them would require rewriting the history.

That shouldn't be hard, and I think it would make it much clearer for people looking back to see what happened if we squashed all the reverts and both of the upgrades together. (It would also be nice to move the package fixes ahead of the meson changes in the PR to avoid having commits where those packages are broken, which would make things easier for people trying to bisect those packages in future.) I'm happy to volunteer to do that rebase if you want.

Where? I only see a green checkmark.

I see the following: (but I'm not sure it's related to Meson)

Test "paths" failed with error: "command test -f /testpath-modified unexpectedly succeeded"

Princemachiavelli and others added 5 commits January 10, 2022 16:49
added graphviz build input for compatability with meson >=0.57.2 see PR meson#8641
We need https://gitlab.freedesktop.org/xdg/shared-mime-info/-/merge_requests/162
("migrate from itstool to msgfmt for creating translated XML") to fix
the build with Meson 0.60.0.

Signed-off-by: Patrick Hilhorst <git@hilhorst.be>
@L-as
Copy link
Member Author

L-as commented Jan 10, 2022

I've rewritten the history. I don't think the test failure is related to Meson.

@L-as
Copy link
Member Author

L-as commented Jan 10, 2022

We probably want to merge this before other PRs introduce more uses of meson_0_60.

@AndersonTorres
Copy link
Member

I'm waiting for ofborg.

@L-as
Copy link
Member Author

L-as commented Jan 11, 2022

There seems to be no issues.

@alyssais alyssais merged commit 41d9dfb into NixOS:staging Jan 11, 2022
@jtojnar
Copy link
Member

jtojnar commented Jan 11, 2022

By the way, 0.61.0 has been released.

@AndersonTorres
Copy link
Member

AndersonTorres commented Jan 12, 2022

And, by the way, with huge patch failure.

Ah, hash = "sha256-6p8zJGsfI/AukKUOdeD0HlJvbavwwk8+AOJ6P1q9w1w=";

meson> unpacking source archive /nix/store/w7d0bjwsgz2nkiy4akg3hbqw9jvfwazd-meson-0.61.0.tar.gz
meson> source root is meson-0.61.0
meson> setting SOURCE_DATE_EPOCH to timestamp 1641832169 of file meson-0.61.0/setup.cfg
meson> patching sources
meson> applying patch /nix/store/pza7hhm23l5qlkb633di8mrf67jp9lbr-allow-dirs-outside-of-prefix.patch
meson> patching file mesonbuild/coredata.py
meson> Hunk #1 succeeded at 564 (offset 58 lines).
meson> Hunk #2 succeeded at 575 (offset 58 lines).
meson> applying patch /nix/store/dgh2dydb2886zvcsvafpighm1y6i4n27-more-env-vars.patch
meson> patching file mesonbuild/environment.py
meson> applying patch /nix/store/1y6lfavd1bzbmv77p29aw7xaqn30ql9h-gir-fallback-path.patch
meson> patching file mesonbuild/modules/gnome.py
meson> Hunk #1 succeeded at 1092 with fuzz 1 (offset 169 lines).
meson> applying patch /nix/store/xgqaxd31i95mfnj3i0xqa8x9bd0m1vl9-fix-rpath.patch
meson> patching file mesonbuild/backend/backends.py
meson> Hunk #1 FAILED at 456.
meson> 1 out of 1 hunk FAILED -- saving rejects to file mesonbuild/backend/backends.py.rej
error: builder for '/nix/store/j6skcz8987ds6nwjj0v0ss0gl2nxw5ma-meson-0.61.0.drv' failed with exit code 1;

@zowoq zowoq mentioned this pull request Jan 14, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants