Skip to content

Comments

[staging-next] aws-sdk-cpp: fix cmake config#153836

Merged
veprbl merged 2 commits intoNixOS:staging-nextfrom
veprbl:pr/aws-sdk-cpp_fix_cmake_config
Jan 8, 2022
Merged

[staging-next] aws-sdk-cpp: fix cmake config#153836
veprbl merged 2 commits intoNixOS:staging-nextfrom
veprbl:pr/aws-sdk-cpp_fix_cmake_config

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Jan 7, 2022

Motivation for this change

Fix arrow-cpp build on darwin https://hydra.nixos.org/build/163358560
Target #152145 if not too many rebuilds

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra January 7, 2022 12:23
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 7, 2022
@veprbl
Copy link
Member Author

veprbl commented Jan 8, 2022

@GrahamcOfBorg build arrow-cpp nix

@veprbl veprbl merged commit ad484cc into NixOS:staging-next Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant