Skip to content

Comments

[staging-next] calibre: fix build on staging-next due to missing setuptools#153795

Merged
jonringer merged 1 commit intoNixOS:staging-nextfrom
LibreCybernetics:calibre-fix-staging-next
Jan 8, 2022
Merged

[staging-next] calibre: fix build on staging-next due to missing setuptools#153795
jonringer merged 1 commit intoNixOS:staging-nextfrom
LibreCybernetics:calibre-fix-staging-next

Conversation

@fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Jan 7, 2022 •
edited
Loading

Motivation for this change

Targetting #152145

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fabianhjr fabianhjr changed the title calibre: fix build on staging-next due to missing setuptools [staging-next] calibre: fix build on staging-next due to missing setuptools Jan 7, 2022
@ofborg ofborg bot requested review from AndersonTorres and pSub January 7, 2022 02:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 7, 2022
@AndersonTorres
Copy link
Member

AndersonTorres commented Jan 7, 2022

Why so much timeout errors on ofborg?

@fabianhjr
Copy link
Member Author

fabianhjr commented Jan 7, 2022

No idea, :o

@fabianhjr fabianhjr mentioned this pull request Jan 8, 2022
Merged
jonringer
jonringer approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 153795 run on x86_64-linux 1

1 package built:
  • calibre

@jonringer
Copy link
Contributor

jonringer commented Jan 8, 2022

@fabianhjr got you fam

@fabianhjr fabianhjr deleted the calibre-fix-staging-next branch January 9, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@pSub pSub Awaiting requested review from pSub

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabianhjr @AndersonTorres @jonringer