python3Packages.flax: init at 0.3.6#153761
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
|
Result of 2 packages built:
|
samuela
left a comment
samuela
left a comment
There was a problem hiding this comment.
LGTM I'll squash and merge tomorrow unless anyone objects
There was a problem hiding this comment.
| description = "Flax is a neural network library for JAX designed for flexibility."; | |
| description = "Neural network library for JAX"; |
I suggest to skip the "marketing" parts. For upstream it's "flexibility" for the average user perhaps "complexity".
There was a problem hiding this comment.
I typically just use the first sentence from the "Description / Overview" section in README to let the authors describe their package in the words they prefer. But no strong preferences from my side, changed to your suggestion.
There was a problem hiding this comment.
The setup.py file is mentioning additional requirements.
There was a problem hiding this comment.
looks like it's only missing jax, perhaps because of a circular dependency issue?
There was a problem hiding this comment.
jax is already pulled in via chex -> optax, in fact it's redundant in their setup.py - not sure why they have it.
ndl
force-pushed
the
submit/flax
branch
2 times, most recently
from
803f9f0 to
54f0507
Compare
|
Just merged, thanks @ndl! I'll use this one myself! |
3 participants
Motivation for this change
Part of "extra JAX libraries / frameworks" implementation, see the discussion in #152754
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes