Skip to content

kitty: fix aarch64-darwin build #153450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cideM wants to merge 1 commit into from
Closed

kitty: fix aarch64-darwin build #153450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/applications/terminal-emulators/kitty/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ buildPythonApplication rec {
# Causes build failure due to warning
hardeningDisable = lib.optional stdenv.cc.isClang "strictoverflow";

preBuild = lib.optionalString (lib.versionAtLeast stdenv.hostPlatform.darwinMinVersion "11" && stdenv.isDarwin) ''
MACOSX_DEPLOYMENT_TARGET=10.16
Copy link
Member

@Mic92 Mic92 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this has any effect? You are not using export here so it would be only accessible to bash but no child processes.

Copy link
Contributor Author

@cideM cideM Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I can say is that without it the build doesn't work on my aarch64-darwin machine and there are other packages that use the same approach in preBuild and preConfigure. I don't know if the fact that this works is accidental or not.

'';

dontConfigure = true;

buildPhase = ''
Expand Down