[staging] llvmPackages_*.clang: stop passing LLVM_CONFIG_PATH unnecessarily#153340
Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom Jan 4, 2022
Merged
Conversation
Member
Author
|
@ofborg build llvmPackages_8.clang-unwrapped |
Member
Author
|
@ofborg build llvmPackages_13.clang-unwrapped |
Member
Author
|
@ofborg build llvmPackages_11.clang-unwrapped |
Starting with LLVM 8, clang does no longer use llvm-config to detect the LLVM installation: llvm/llvm-project@e4faa5c7986b7 Consequently, there is no point passing LLVM_CONFIG_PATH (in fact the variable is unused currently).
91151b7 to
c58517a
Compare
Contributor
|
Isn't this needed for mesa cross-compilation? Edit: oh, it's only for clang. Then I guess it isn't needed. |
Member
|
Horry to one less annoying config tool! |
Contributor
|
Backport failed for Please cherry-pick the changes locally. git fetch origin staging-21.11
git worktree add -d .worktree/backport-153340-to-staging-21.11 origin/staging-21.11
cd .worktree/backport-153340-to-staging-21.11
git checkout -b backport-153340-to-staging-21.11
ancref=$(git merge-base c6f7ec4c2a6b2910f53d083fd2a8d191d72758ac c58517aeed3ee840a0d92455e4f4231f2396d73f)
git cherry-pick -x $ancref..c58517aeed3ee840a0d92455e4f4231f2396d73f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with LLVM 8, clang does no longer use llvm-config to detect the
LLVM installation: llvm/llvm-project@e4faa5c7986b7
Consequently, there is no point passing LLVM_CONFIG_PATH (in fact the
variable is unused currently).
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes