Skip to content

tensorflow: init at 0.8.0#15329

Merged
joachifm merged 1 commit intoNixOS:masterfrom
anderspapitto:tensorflow
May 15, 2016
Merged

tensorflow: init at 0.8.0#15329
joachifm merged 1 commit intoNixOS:masterfrom
anderspapitto:tensorflow

Conversation

@anderspapitto
Copy link
Contributor

@anderspapitto anderspapitto commented May 9, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package labels May 10, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for installing wheels was added in #15010. It suffices to add the argument format="wheel".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched it to use format = "wheel";. Do you want me to also take the comment out? I'd like to leave it in, because there is unfinished work here, and it would be better to eventually build from source - for example, because then we wouldn't need the preFixup stage below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I am glad you put the comment here.

@joachifm
Copy link
Contributor

While I think listing all the licenses is a good service to our users, what really matters is that none of the bundled sources are licensed in a way that makes it illegal to redistribute the whole. I'd find it incredibly deceptive if upstream provides a bundle that is in fact illegal to distribute, given that their advertised license certainly permits it.

@joachifm
Copy link
Contributor

Thank you

@joachifm joachifm merged commit 3a5781a into NixOS:master May 15, 2016
@anderspapitto anderspapitto deleted the tensorflow branch March 10, 2018 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants