Skip to content

Comments

gd: 2.0.35 -> 2.1.1#15323

Merged
joachifm merged 5 commits intoNixOS:masterfrom
joachifm:libgd
May 15, 2016
Merged

gd: 2.0.35 -> 2.1.1#15323
joachifm merged 5 commits intoNixOS:masterfrom
joachifm:libgd

Conversation

@joachifm
Copy link
Contributor

@joachifm joachifm commented May 9, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @edolstra to be a potential reviewer

@joachifm
Copy link
Contributor Author

I have included a patch for CVE-2016-3074 from upstream.

joachifm added 2 commits May 14, 2016 07:15
Upstream claims 2.1 is fully API compatible with 2.0

https://libgd.github.io/release-2.1.0.html
https://libgd.github.io/release-2.1.1.html

Also includes meta updates, adds pkg-config to the build environment,
for proper detection of dependencies, and adds optional support for tiff
and xpm image formats.
Source:
https://github.com/libgd/libgd/commit/2bb97f407c1145c850416a3bfbcc8cf124e68a19.patch

The original patch contains binary data, however, which is not supported
by `patch`; we could use `git apply` here, of course, but it was simpler
to just copy-paste only the fix into a separate file and include it in
the repo.
@joachifm
Copy link
Contributor Author

I've successfully built all but one package (hhvm, too large for me to tackle) that directly depends on gd. Per the changelog, this should be safe, so barring objections, I'll merge this soon.

joachifm added 3 commits May 14, 2016 07:41
Possibly jpeg used to be propagated from gd but is no longer after
f8bdd79.
Possibly jpeg used to be propagated from gd but is no longer after
f8bdd79.
Possibly jpeg used to be propagated from gd but is no longer after
f8bdd79.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants