Conversation
|
By analyzing the blame information on this pull request, we identified @edolstra to be a potential reviewer |
Contributor
Author
|
I have included a patch for CVE-2016-3074 from upstream. |
Upstream claims 2.1 is fully API compatible with 2.0 https://libgd.github.io/release-2.1.0.html https://libgd.github.io/release-2.1.1.html Also includes meta updates, adds pkg-config to the build environment, for proper detection of dependencies, and adds optional support for tiff and xpm image formats.
Source: https://github.com/libgd/libgd/commit/2bb97f407c1145c850416a3bfbcc8cf124e68a19.patch The original patch contains binary data, however, which is not supported by `patch`; we could use `git apply` here, of course, but it was simpler to just copy-paste only the fix into a separate file and include it in the repo.
Contributor
Author
|
I've successfully built all but one package ( |
This was referenced Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)