Skip to content

libpulseaudio: fix aarch64-darwin build#153220

Merged
bobby285271 merged 1 commit intoNixOS:stagingfrom
mikroskeem:darwin-fix-libpulseaudio-aarch64
Jan 3, 2022
Merged

libpulseaudio: fix aarch64-darwin build#153220
bobby285271 merged 1 commit intoNixOS:stagingfrom
mikroskeem:darwin-fix-libpulseaudio-aarch64

Conversation

@mikroskeem
Copy link
Member

Removes darwin Libc buildInput, which does not appear to be needed on
x86_64, and which does not support aarch64 at all (too old)

Motivation for this change

#152371 but targeting staging branch this time.

@bobby285271

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Removes darwin Libc buildInput, which does not appear to be needed on
x86_64, and which does not support aarch64 at all (too old)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 2, 2022
@Mic92
Copy link
Member

Mic92 commented Jan 2, 2022

@ofborg build pulseaudio

@ofborg ofborg bot requested a review from lovek323 January 2, 2022 17:33
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jan 2, 2022
@bobby285271
Copy link
Member

Thanks, this looks good to me.

I think pulseaudio (with useSystemd and bluetoothSupport disabled) does not build on x86_64-darwin currently. libpulseaudio builds on x86_64-darwin and aarch64-darwin according to build result from the previous PR.

@bobby285271 bobby285271 merged commit f23c7f1 into NixOS:staging Jan 3, 2022
@mikroskeem
Copy link
Member Author

Looking at the derivation, seems like it was never intended to make pulseaudio buildable on Darwin, which is fine for now. It needs to be refactored (buildInputs etc) to get it to build properly.

All derivations which I've encountered just need ‘libpulseaudio`. From last nixpkgs-review I did, this fixed almost 80 builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments